Conversation
Contributor
WalkthroughThe pull request updates two test files by enabling their respective test suites. This is achieved by changing the description from Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (5)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
github-actions
bot
added
the
skip-changelog
KelvinOm
reviewed
Mar 14, 2025
| import { PageFactory } from "test/factories/PageFactory"; | ||
| import { JSObjectFactory } from "test/factories/Actions/JSObject"; | ||
|
|
||
| // Mock JSEditorForm component |
Collaborator
There was a problem hiding this comment.
@hetunandu Thanks for the PR. I see that the execution time of JsRender has decreased by 2 times, but the execution time of QueryReader is still the same. Could you check why this is so?
The timeout is also triggered for each individual it, so you can check which it takes which time with logs, like this
beforeEach(() => {
testStartTime = Date.now();
});
afterEach(() => {
const testDuration = Date.now() - testStartTime;
console.log(`🕒 Test "${expect.getState().currentTestName}" took ${testDuration}ms`);
});
Member
Author
There was a problem hiding this comment.
Not able to remove anything that is not critical. But it is under limits now so we should be good.
Collaborator
There was a problem hiding this comment.
We can mock not only direct imports, but also what is imported above. Anyway, approved.
I wonder if AI can help mock what's not needed and make tests faster? 🤔
KelvinOm
approved these changes
Mar 14, 2025
github-actions bot
pushed a commit
to Zeral-Zhang/appsmith
that referenced
this pull request
Apr 12, 2025
## Description Mocks a few heavy components that were causing a timeout for IDE tests in EE. EE PR for tests: appsmithorg/appsmith-ee#6580 ## Automation /ok-to-test tags="@tag.IDE" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13855339158> > Commit: 205a69f > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13855339158&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.IDE` > Spec: > <hr>Fri, 14 Mar 2025 11:40:35 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Tests** - Improved test coverage for our code editor interfaces with enhanced component isolation through mocking. - Reactivated previously skipped tests to ensure robust quality validation. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Mocks a few heavy components that were causing a timeout for IDE tests in EE.
EE PR for tests: https://github.com/appsmithorg/appsmith-ee/pull/6580
Automation
/ok-to-test tags="@tag.IDE"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13855339158
Commit: 205a69f
Cypress dashboard.
Tags:
@tag.IDESpec:
Fri, 14 Mar 2025 11:40:35 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit